From c5cde5193e628e2e3e2aa0ed7e6ae7908826cc8d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Holger=20Hanke?= <andre.hanke@mni.thm.de>
Date: Thu, 24 Oct 2019 20:00:24 +0200
Subject: [PATCH] Resolve "Tab navigation in dialogs"
---
.../_dialogs/delete-account/delete-account.component.html | 6 +++---
.../user-bonus-token/user-bonus-token.component.html | 8 ++++----
src/app/components/shared/header/header.component.html | 8 ++++----
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/app/components/shared/_dialogs/delete-account/delete-account.component.html b/src/app/components/shared/_dialogs/delete-account/delete-account.component.html
index 17dbe121e..c6c9f65eb 100644
--- a/src/app/components/shared/_dialogs/delete-account/delete-account.component.html
+++ b/src/app/components/shared/_dialogs/delete-account/delete-account.component.html
@@ -1,9 +1,9 @@
<div mat-dialog-content>
<div style="overflow-y: scroll; max-height: 15rem">
- <h2>{{ 'header.sure' | translate }}</h2>
+ <h2 tabindex="0">{{ 'header.sure' | translate }}</h2>
<mat-divider></mat-divider>
- <p>{{ 'header.really-delete-account' | translate }}</p>
- <ul *ngFor="let room of rooms">
+ <p tabindex="0">{{ 'header.really-delete-account' | translate }}</p>
+ <ul *ngFor="let room of rooms" tabindex="0">
<li>{{ room.name }}</li>
</ul>
</div>
diff --git a/src/app/components/shared/_dialogs/user-bonus-token/user-bonus-token.component.html b/src/app/components/shared/_dialogs/user-bonus-token/user-bonus-token.component.html
index e76d470b1..0cd154cb8 100644
--- a/src/app/components/shared/_dialogs/user-bonus-token/user-bonus-token.component.html
+++ b/src/app/components/shared/_dialogs/user-bonus-token/user-bonus-token.component.html
@@ -1,15 +1,15 @@
<div mat-dialog-content>
- <h2>{{'header.bonus-token' | translate }}</h2>
+ <h1 tabindex="0">{{'header.bonus-token' | translate }}</h1>
<mat-divider></mat-divider>
<div *ngIf="bonusTokens.length >= 1">
<div fxLayout="row" *ngFor="let bonusToken of bonusTokens">
- <p>
+ <h2 tabindex="1">
{{bonusToken.token}}
- </p>
+ </h2>
</div>
</div>
<div *ngIf="bonusTokens.length === 0">
- <p>{{'header.no-bonus' | translate }}</p>
+ <h3 tabindex="0">{{'header.no-bonus' | translate }}</h3>
</div>
<app-dialog-action-buttons
buttonsLabelSection="introduction"
diff --git a/src/app/components/shared/header/header.component.html b/src/app/components/shared/header/header.component.html
index 29c3faa3c..37de7a17e 100644
--- a/src/app/components/shared/header/header.component.html
+++ b/src/app/components/shared/header/header.component.html
@@ -29,20 +29,20 @@
<span class="fill-remaining-space"></span>
<mat-menu #userMenu="matMenu" [overlapTrigger]="false">
- <button mat-menu-item *ngIf="user" routerLink="/user">
+ <button mat-menu-item *ngIf="user" routerLink="/user" tabindex="0">
<mat-icon class="sessions">people</mat-icon>
<span *ngIf="!user.isGuest">{{'header.my-sessions' | translate}}</span>
<span *ngIf="user.isGuest" svgIcon="meeting_room">{{'header.visited-sessions' | translate}}</span>
</button>
- <button mat-menu-item *ngIf="user" (click)="openUserBonusTokenDialog()">
+ <button mat-menu-item *ngIf="user" (click)="openUserBonusTokenDialog()" tabindex="0">
<mat-icon color="warn">grade</mat-icon>
<span>{{'header.user-bonus-token' | translate}}</span>
</button>
- <button mat-menu-item *ngIf="user && !user.isGuest" (click)="openDeleteUserDialog()">
+ <button mat-menu-item *ngIf="user && !user.isGuest" (click)="openDeleteUserDialog()" tabindex="0">
<mat-icon color="warn">delete</mat-icon>
<span>{{'header.delete-account' | translate}}</span>
</button>
- <button mat-menu-item (click)="logout()">
+ <button mat-menu-item (click)="logout()" tabindex="0">
<mat-icon color="warn">exit_to_app</mat-icon>
<span>{{ 'header.logout' | translate }}</span>
</button>
--
GitLab