From 957d98397b241aad7e3a638e61f5b43f5b881f00 Mon Sep 17 00:00:00 2001
From: Muhammet Ali Erbay <muhammet.erbay@mni.thm.de>
Date: Fri, 13 Sep 2019 12:15:54 +0200
Subject: [PATCH] Resolve "change description for voting buttons"

---
 .../components/shared/comment/comment.component.html   |  3 +--
 src/assets/i18n/creator/de.json                        | 10 +++++-----
 src/assets/i18n/creator/en.json                        |  6 +++---
 src/assets/i18n/participant/de.json                    | 10 +++++-----
 src/assets/i18n/participant/en.json                    |  6 +++---
 5 files changed, 17 insertions(+), 18 deletions(-)

diff --git a/src/app/components/shared/comment/comment.component.html b/src/app/components/shared/comment/comment.component.html
index 10168fd7b..fd9e89255 100644
--- a/src/app/components/shared/comment/comment.component.html
+++ b/src/app/components/shared/comment/comment.component.html
@@ -56,8 +56,7 @@
         <span aria-hidden="true">{{ comment.body.trim() }}</span>
         <span id="comment-{{ comment.id }}" class="visually-hidden" aria-hidden="true">{{ 'comment-page.comment' | translate: {
             time: (language === 'de' ? (comment.timestamp | date: ' HH:mm ') : (comment.timestamp | date: 'h:mm a')),
-            votes: comment.score,
-            textForVotes: comment.score === 1 ? ('comment-page.a11y-text_textForOneVote' | translate) : ('comment-page.a11y-text_textForVotes' | translate),
+            votes: comment.score === 1 ? ('comment-page.a11y-text_textForOneVote' | translate) : comment.score + ('comment-page.a11y-text_textForVotes' | translate),
             comment: comment.body.trim(),
             correct: comment.correct === 1 ? ('comment-page.a11y-text_correct' | translate) : "",
             wrong: comment.correct === 2 ? ('comment-page.a11y-text_wrong' | translate) : "",
diff --git a/src/assets/i18n/creator/de.json b/src/assets/i18n/creator/de.json
index b00c822f1..80c7c3edf 100644
--- a/src/assets/i18n/creator/de.json
+++ b/src/assets/i18n/creator/de.json
@@ -38,20 +38,20 @@
     "a11y-comment_not_grade": "Hebt die Bonus Markierung auf",
     "a11y-comment_not_marked_correct": "Bejaht diese Frage",
     "a11y-comment_not_marked_wrong": "Verneint diese Frage",
-    "a11y-comment_vote_down": "Stimmt dieser Frage ab",
-    "a11y-comment_vote_up": "Stimmt dieser Frage zu",
+    "a11y-comment_vote_down": "Diese Frage runter woten",
+    "a11y-comment_vote_up": "Diese Frage hoch woten",
     "a11y-text_correct": "Diese Frage wurde bejaht.",
     "a11y-text_grade": "Diese Frage wurde als Bonus Frage markiert.",
     "a11y-text_read": "Diese Frage wurde in Vollansicht am Beamer besprochen.",
-    "a11y-text_textForOneVote": "Stimme",
-    "a11y-text_textForVotes": "Stimmen",
+    "a11y-text_textForOneVote": " Ein ,Vote",
+    "a11y-text_textForVotes": ",Wouuts",
     "a11y-text_wrong": "Diese Frage wurde verneint.",
     "abort": "Abbrechen",
     "ask-question-description": "Gib hier deine Frage ein!",
     "acknowledge": "Erlauben",
     "cancel": "Zurück",
     "cancel-description": "Zurück",
-    "comment": "Die Frage {{ comment }} wurde um {{ time }} Uhr gestellt und hat derzeitig {{ votes }} {{textForVotes}}. {{correct}} {{wrong}} {{bonus}} {{beamer}}",
+    "comment": "Die Frage {{ comment }} wurde um {{ time }} Uhr gestellt und hat derzeitig {{ votes }}. {{correct}} {{wrong}} {{bonus}} {{beamer}}",
     "comma": "Microsoft Excel",
     "delete": "Frage löschen",
     "delimiter": "Bitte wähle ein Format!",
diff --git a/src/assets/i18n/creator/en.json b/src/assets/i18n/creator/en.json
index 28867feca..7e58371aa 100644
--- a/src/assets/i18n/creator/en.json
+++ b/src/assets/i18n/creator/en.json
@@ -43,8 +43,8 @@
     "a11y-text_correct": "This question was marked as correct.",
     "a11y-text_grade": "This question was marked as a bonus question.",
     "a11y-text_read": "This question was discussed in full view on the beamer",
-    "a11y-text_textForOneVote": "Vote",
-    "a11y-text_textForVotes": "Votes",
+    "a11y-text_textForOneVote": "One ,Vote",
+    "a11y-text_textForVotes": ",Votes",
     "a11y-text_wrong": "This question was marked as not correct.",
     "abort": "Cancel",
     "acknowledge": "Acknowledge",
@@ -52,7 +52,7 @@
     "cancel": "Cancel",
     "cancel-description": "Cancel",
     "comma": "Microsoft Excel",
-    "comment": "Question {{ comment }} was asked at {{ time }} and has currently {{ votes }} {{textForVotes}}. {{correct}} {{wrong}} {{bonus}} {{beamer}}",
+    "comment": "Question {{ comment }} was asked at {{ time }} and has currently {{ votes }}. {{correct}} {{wrong}} {{bonus}} {{beamer}}",
     "delete": "Delete question",
     "delimiter": "Please choose a format!",
     "enter-comment": "Question",
diff --git a/src/assets/i18n/participant/de.json b/src/assets/i18n/participant/de.json
index b4b5a718e..f036a0215 100644
--- a/src/assets/i18n/participant/de.json
+++ b/src/assets/i18n/participant/de.json
@@ -40,19 +40,19 @@
   },
   "comment-page": {
     "a11y-comment_input": "Geben sie Ihre Frage ein",
-    "a11y-comment_vote_down": "Stimmt dieser Frage ab",
-    "a11y-comment_vote_up": "Stimmt dieser Frage zu",
+    "a11y-comment_vote_down": "Diese Frage runter woten",
+    "a11y-comment_vote_up": "Diese Frage hoch woten",
     "a11y-text_correct": "Diese Frage wurde bejaht.",
     "a11y-text_grade": "Diese Frage wurde als Bonus Frage markiert.",
     "a11y-text_read": "Diese Frage wurde in Vollansicht am Beamer besprochen.",
-    "a11y-text_textForOneVote": "Stimme",
-    "a11y-text_textForVotes": "Stimmen",
+    "a11y-text_textForOneVote": "Ein ,Vote",
+    "a11y-text_textForVotes": ",Wouuts",
     "a11y-text_wrong": "Diese Frage wurde verneint.",
     "abort": "Abbrechen",
     "ask-question-description": "Gib hier deine Frage ein!",
     "cancel": "Zurück",
     "cancel-description": "Zurück",
-    "comment": "Die Frage {{ comment }} wurde um {{ time }} Uhr gestellt und hat derzeitig {{ votes }} {{textForVotes}}. {{correct}} {{wrong}} {{bonus}} {{beamer}}",
+    "comment": "Die Frage {{ comment }} wurde um {{ time }} Uhr gestellt und hat derzeitig {{ votes }}. {{correct}} {{wrong}} {{bonus}} {{beamer}}",
     "enter-comment": "Deine Frage",
     "enter-title": "Titel",
     "error-both-fields": "Bitte fülle alle Felder aus.",
diff --git a/src/assets/i18n/participant/en.json b/src/assets/i18n/participant/en.json
index 06201e7d3..82860d1a9 100644
--- a/src/assets/i18n/participant/en.json
+++ b/src/assets/i18n/participant/en.json
@@ -45,14 +45,14 @@
     "a11y-text_correct": "This question was marked as correct.",
     "a11y-text_grade": "This question was marked as a bonus question.",
     "a11y-text_read": "This question was discussed in full view on the beamer",
-    "a11y-text_textForOneVote": "Vote",
-    "a11y-text_textForVotes": "Votes",
+    "a11y-text_textForOneVote": "One ,Vote",
+    "a11y-text_textForVotes": ",Votes",
     "a11y-text_wrong": "This question was marked as not correct.",
     "abort": "Cancel",
     "ask-question-description": "Enter your question here!",
     "cancel": "Cancel",
     "cancel-description": "Cancel",
-    "comment": "Question {{ comment }} was asked at {{ time }} and has currently {{ votes }} {{textForVotes}}. {{correct}} {{wrong}} {{bonus}} {{beamer}}",
+    "comment": "Question {{ comment }} was asked at {{ time }} and has currently {{ votes }}. {{correct}} {{wrong}} {{bonus}} {{beamer}}",
     "enter-comment": "Your question",
     "enter-title": "Title",
     "error-both-fields": "Please fill in all fields.",
-- 
GitLab