Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
cards
cards
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 103
    • Issues 103
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • ARSnova
  • cardscards
  • Issues
  • #448

Closed
Open
Opened May 31, 2020 by Curtis Adam@cadm74Maintainer0 of 8 tasks completed0/8 tasks

Replace jshint and jscs with ESLint

JSCS is very outdated and got merged with ESLint. If we switch over to ESLint then we also won't need to use jshint any longer. I would suggest going with the predefined Google guidelines (Minus the max-length check for lines). This will require a lot of refactoring for many files in the client, i18n, imports and server folders but...

  • There is less setup to enable ESLint in Webstorm compared to jshint and jscs
  • Webstorm seems to have better support for ESLint
  • You can auto-convert files to the new ESLint rules
  • The rules will force us to write cleaner code
  • We have a lot of questionable jshint and jscs rules in cards since the move to 3.0

Progress for folders:

  • client
  • imports/api
  • imports/config
  • imports/startup
  • imports/ui
  • imports/util
  • server

Misc:

  • Integrated to pipeline
Edited Dec 08, 2020 by Curtis Adam
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: arsnova/cards#448