From b542ec57df0edebeb56fd69390fa0f55bbf4e659 Mon Sep 17 00:00:00 2001 From: Paul-Christian Volkmer <github@pcvolkmer.de> Date: Mon, 11 Dec 2017 06:24:27 +0100 Subject: [PATCH] Use try-with-resource statement to close stream on exception Cherry-picked from GH-51. --- src/main/java/de/thm/arsnova/ImageUtils.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/main/java/de/thm/arsnova/ImageUtils.java b/src/main/java/de/thm/arsnova/ImageUtils.java index 111e6c1f0..51af7e112 100644 --- a/src/main/java/de/thm/arsnova/ImageUtils.java +++ b/src/main/java/de/thm/arsnova/ImageUtils.java @@ -230,11 +230,9 @@ public class ImageUtils { * @return The <code>byte[]</code> of the image on success, otherwise <code>null</code>. */ byte[] convertFileToByteArray(final String imageUrl) { - try { - final URL url = new URL(imageUrl); + try (InputStream is = new URL(imageUrl).openStream()) { final ByteArrayOutputStream baos = new ByteArrayOutputStream(); - final InputStream is = url.openStream(); final byte[] byteChunk = new byte[CHUNK_SIZE]; int n; -- GitLab