From 4aa6d35cc3db0e7258f8adfbabaa6927ea79ed89 Mon Sep 17 00:00:00 2001
From: Daniel Gerhardt <code@dgerhardt.net>
Date: Mon, 27 Mar 2017 14:18:34 +0200
Subject: [PATCH] Add comments to methods with annotations but no
implementation
Additionally, removed unused empty constructor
---
.../controller/SecurityExceptionControllerAdvice.java | 9 +++++++++
.../arsnova/entities/transport/ImportExportSession.java | 4 ----
.../de/thm/arsnova/socket/ARSnovaSocketIOServer.java | 4 +++-
3 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/src/main/java/de/thm/arsnova/controller/SecurityExceptionControllerAdvice.java b/src/main/java/de/thm/arsnova/controller/SecurityExceptionControllerAdvice.java
index 128b63dee..48111c536 100644
--- a/src/main/java/de/thm/arsnova/controller/SecurityExceptionControllerAdvice.java
+++ b/src/main/java/de/thm/arsnova/controller/SecurityExceptionControllerAdvice.java
@@ -62,16 +62,19 @@ public class SecurityExceptionControllerAdvice {
@ResponseStatus(HttpStatus.NOT_FOUND)
@ExceptionHandler(NotFoundException.class)
public void handleNotFoundException(final Exception e, final HttpServletRequest request) {
+ /* No implementation - handled solely by annotations */
}
@ResponseStatus(HttpStatus.UNAUTHORIZED)
@ExceptionHandler(UnauthorizedException.class)
public void handleUnauthorizedException(final Exception e, final HttpServletRequest request) {
+ /* No implementation - handled solely by annotations */
}
@ResponseStatus(HttpStatus.UNAUTHORIZED)
@ExceptionHandler(AuthenticationCredentialsNotFoundException.class)
public void handleAuthenticationCredentialsNotFoundException(final Exception e, final HttpServletRequest request) {
+ /* No implementation - handled solely by annotations */
}
@ExceptionHandler(AccessDeniedException.class)
@@ -95,30 +98,36 @@ public class SecurityExceptionControllerAdvice {
@ResponseStatus(HttpStatus.FORBIDDEN)
@ExceptionHandler(ForbiddenException.class)
public void handleForbiddenException(final Exception e, final HttpServletRequest request) {
+ /* No implementation - handled solely by annotations */
}
@ResponseStatus(HttpStatus.NO_CONTENT)
@ExceptionHandler(NoContentException.class)
public void handleNoContentException(final Exception e, final HttpServletRequest request) {
+ /* No implementation - handled solely by annotations */
}
@ResponseStatus(HttpStatus.BAD_REQUEST)
@ExceptionHandler(BadRequestException.class)
public void handleBadRequestException(final Exception e, final HttpServletRequest request) {
+ /* No implementation - handled solely by annotations */
}
@ResponseStatus(HttpStatus.PRECONDITION_FAILED)
@ExceptionHandler(PreconditionFailedException.class)
public void handlePreconditionFailedException(final Exception e, final HttpServletRequest request) {
+ /* No implementation - handled solely by annotations */
}
@ResponseStatus(HttpStatus.NOT_IMPLEMENTED)
@ExceptionHandler(NotImplementedException.class)
public void handleNotImplementedException(final Exception e, final HttpServletRequest request) {
+ /* No implementation - handled solely by annotations */
}
@ResponseStatus(HttpStatus.PAYLOAD_TOO_LARGE)
@ExceptionHandler(PayloadTooLargeException.class)
public void handlePayloadTooLargeException(final Exception e, final HttpServletRequest request) {
+ /* No implementation - handled solely by annotations */
}
}
diff --git a/src/main/java/de/thm/arsnova/entities/transport/ImportExportSession.java b/src/main/java/de/thm/arsnova/entities/transport/ImportExportSession.java
index 02a01e975..baa967242 100644
--- a/src/main/java/de/thm/arsnova/entities/transport/ImportExportSession.java
+++ b/src/main/java/de/thm/arsnova/entities/transport/ImportExportSession.java
@@ -155,10 +155,6 @@ public class ImportExportSession {
private List<Answer> answers;
- public ImportExportQuestion() {
-
- }
-
public ImportExportQuestion(Question q) {
setType(q.getType());
setQuestionType(q.getQuestionType());
diff --git a/src/main/java/de/thm/arsnova/socket/ARSnovaSocketIOServer.java b/src/main/java/de/thm/arsnova/socket/ARSnovaSocketIOServer.java
index a328cae2f..b8398d9e6 100644
--- a/src/main/java/de/thm/arsnova/socket/ARSnovaSocketIOServer.java
+++ b/src/main/java/de/thm/arsnova/socket/ARSnovaSocketIOServer.java
@@ -230,7 +230,9 @@ public class ARSnovaSocketIOServer implements ARSnovaSocket, NovaEventVisitor {
server.addConnectListener(new ConnectListener() {
@Override
@Timed
- public void onConnect(final SocketIOClient client) { }
+ public void onConnect(final SocketIOClient client) {
+ /* No implementation - only used for monitoring */
+ }
});
server.addDisconnectListener(new DisconnectListener() {
--
GitLab