From 053e76b0499863a5e46ef5e0c537bd54e00dcd0c Mon Sep 17 00:00:00 2001
From: Daniel Gerhardt <code@dgerhardt.net>
Date: Sat, 10 Aug 2019 20:25:53 +0200
Subject: [PATCH] Add comment to or remove methods w/o implementation

---
 .../de/thm/arsnova/cache/CacheBusterImpl.java    | 12 ++++++------
 .../thm/arsnova/cache/ScheduledCacheBuster.java  | 16 ++++++++--------
 .../service/DefaultEntityServiceImpl.java        | 12 ++++++------
 .../websocket/ArsnovaSocketioServerImpl.java     |  8 --------
 4 files changed, 20 insertions(+), 28 deletions(-)

diff --git a/src/main/java/de/thm/arsnova/cache/CacheBusterImpl.java b/src/main/java/de/thm/arsnova/cache/CacheBusterImpl.java
index 4d8a7ed92..30c13fac7 100644
--- a/src/main/java/de/thm/arsnova/cache/CacheBusterImpl.java
+++ b/src/main/java/de/thm/arsnova/cache/CacheBusterImpl.java
@@ -39,36 +39,36 @@ public class CacheBusterImpl implements CacheBuster {
 	@CacheEvict(value = "statistics", allEntries = true)
 	@EventListener
 	public void handleAfterCommentCreation(final AfterCreationEvent<Comment> event) {
-
+		/* Implementation provided by caching aspect. */
 	}
 
 	@CacheEvict(value = "statistics", allEntries = true)
 	@EventListener
 	public void handleAfterCommentDeletion(final AfterDeletionEvent<Comment> event) {
-
+		/* Implementation provided by caching aspect. */
 	}
 
 	@CacheEvict(value = "answerlists", key = "#event.content.id")
 	@EventListener
 	public void handleAfterAnswerCreation(final AfterCreationEvent<Answer> event) {
-
+		/* Implementation provided by caching aspect. */
 	}
 
 	@CacheEvict(value = "statistics", allEntries = true)
 	@EventListener
 	public void handleChangeScore(final ChangeScoreEvent event) {
-
+		/* Implementation provided by caching aspect. */
 	}
 
 	@CacheEvict(value = "statistics", allEntries = true)
 	@EventListener
 	public void handleAfterRoomCreation(final AfterCreationEvent<Room> event) {
-
+		/* Implementation provided by caching aspect. */
 	}
 
 	@CacheEvict(value = "statistics", allEntries = true)
 	@EventListener
 	public void handleAfterRoomDeletion(final AfterDeletionEvent<Room> event) {
-
+		/* Implementation provided by caching aspect. */
 	}
 }
diff --git a/src/main/java/de/thm/arsnova/cache/ScheduledCacheBuster.java b/src/main/java/de/thm/arsnova/cache/ScheduledCacheBuster.java
index fa9e37d23..0db951898 100644
--- a/src/main/java/de/thm/arsnova/cache/ScheduledCacheBuster.java
+++ b/src/main/java/de/thm/arsnova/cache/ScheduledCacheBuster.java
@@ -41,49 +41,49 @@ public class ScheduledCacheBuster {
 	@CacheEvict(value = "rooms", allEntries = true)
 	@Scheduled(initialDelay = 1000 * 25, fixedRate = 1000 * 60 * 60 * 6)
 	private void clearSessionCache() {
-
+		/* Implementation provided by caching aspect. */
 	}
 
 	@CacheEvict(value = "contents", allEntries = true)
 	@Scheduled(initialDelay = 1000 * 50, fixedRate = 1000 * 60 * 30)
 	private void clearQuestionCache() {
-
+		/* Implementation provided by caching aspect. */
 	}
 
 	@CacheEvict(value = "contentlists", allEntries = true)
 	@Scheduled(initialDelay = 1000 * 75, fixedRate = 1000 * 60 * 30)
 	private void clearSkillQuestionCache() {
-
+		/* Implementation provided by caching aspect. */
 	}
 
 	@CacheEvict(value = "lecturecontentlists", allEntries = true)
 	@Scheduled(initialDelay = 1000 * 100, fixedRate = 1000 * 60 * 30)
 	private void clearLectureQuestionCache() {
-
+		/* Implementation provided by caching aspect. */
 	}
 
 	@CacheEvict(value = "preparationcontentlists", allEntries = true)
 	@Scheduled(initialDelay = 1000 * 125, fixedRate = 1000 * 60 * 30)
 	private void clearPreparationQuestionCache() {
-
+		/* Implementation provided by caching aspect. */
 	}
 
 	@CacheEvict(value = "flashcardcontentlists", allEntries = true)
 	@Scheduled(initialDelay = 1000 * 150, fixedRate = 1000 * 60 * 30)
 	private void clearFlashcardQuestionCache() {
-
+		/* Implementation provided by caching aspect. */
 	}
 
 	@CacheEvict(value = "answerlists", allEntries = true)
 	@Scheduled(initialDelay = 1000 * 175, fixedRate = 1000 * 60 * 15)
 	private void clearAnswerCache() {
-
+		/* Implementation provided by caching aspect. */
 	}
 
 	@CacheEvict(value = "score", allEntries = true)
 	@Scheduled(initialDelay = 1000 * 200, fixedRate = 1000 * 60 * 15)
 	private void clearLearningProgressCache() {
-
+		/* Implementation provided by caching aspect. */
 	}
 
 }
diff --git a/src/main/java/de/thm/arsnova/service/DefaultEntityServiceImpl.java b/src/main/java/de/thm/arsnova/service/DefaultEntityServiceImpl.java
index 731fba023..ac3d03a27 100644
--- a/src/main/java/de/thm/arsnova/service/DefaultEntityServiceImpl.java
+++ b/src/main/java/de/thm/arsnova/service/DefaultEntityServiceImpl.java
@@ -130,7 +130,7 @@ public class DefaultEntityServiceImpl<T extends Entity> implements EntityService
 	 * @param entity The entity to be created
 	 */
 	protected void prepareCreate(final T entity) {
-
+		/* Implementation provided by subclasses. */
 	}
 
 	/**
@@ -139,7 +139,7 @@ public class DefaultEntityServiceImpl<T extends Entity> implements EntityService
 	 * @param entity The entity which has been created
 	 */
 	protected void finalizeCreate(final T entity) {
-
+		/* Implementation provided by subclasses. */
 	}
 
 	public T update(final T entity) {
@@ -169,7 +169,7 @@ public class DefaultEntityServiceImpl<T extends Entity> implements EntityService
 	 * @param entity The entity to be updated
 	 */
 	protected void prepareUpdate(final T entity) {
-
+		/* Implementation provided by subclasses. */
 	}
 
 	/**
@@ -178,7 +178,7 @@ public class DefaultEntityServiceImpl<T extends Entity> implements EntityService
 	 * @param entity The entity which has been updated
 	 */
 	protected void finalizeUpdate(final T entity) {
-
+		/* Implementation provided by subclasses. */
 	}
 
 	@Override
@@ -272,7 +272,7 @@ public class DefaultEntityServiceImpl<T extends Entity> implements EntityService
 	 * @param entity The entity to be deleted
 	 */
 	protected void prepareDelete(final T entity) {
-
+		/* Implementation provided by subclasses. */
 	}
 
 	/**
@@ -282,7 +282,7 @@ public class DefaultEntityServiceImpl<T extends Entity> implements EntityService
 	 * @param entity The entity to be modified
 	 */
 	protected void modifyRetrieved(final T entity) {
-
+		/* Implementation provided by subclasses. */
 	}
 
 	protected void validate(final T entity) {
diff --git a/src/main/java/de/thm/arsnova/websocket/ArsnovaSocketioServerImpl.java b/src/main/java/de/thm/arsnova/websocket/ArsnovaSocketioServerImpl.java
index 2391cd978..ace674a81 100644
--- a/src/main/java/de/thm/arsnova/websocket/ArsnovaSocketioServerImpl.java
+++ b/src/main/java/de/thm/arsnova/websocket/ArsnovaSocketioServerImpl.java
@@ -278,14 +278,6 @@ public class ArsnovaSocketioServerImpl implements ArsnovaSocketioServer {
 					}
 				});
 
-		server.addConnectListener(new ConnectListener() {
-			@Override
-			@Timed("onConnect")
-			public void onConnect(final SocketIOClient client) {
-
-			}
-		});
-
 		server.addDisconnectListener(new DisconnectListener() {
 			@Override
 			@Timed("onDisconnect")
-- 
GitLab